What bad practices? From what I can see all the variables are (And should be) included from a configuration page.
Do you have any performance benchmarks that show using switch() is "much more efficient"?
Explain how it would be much better if he used switch(). You are making assertions that you have yet to back up. Questioning such claims is not spamming. I also like how disregarded the portion of my post asking you to show how using switch() is "much more efficient" than using if/else.
So do you admit that you were wrong about switch() being "much more efficient"?
I find it sad that you think me questioning some of your wild claims is the equivalent of a win/lose type situation. Finding out you were wrong about something shouldn't be considered a 'loss'. Unless, of course, you have an insecure ego.
<?php
/*------------------------------------------------------------------------|
| Zinim - Copyright (c) Josh Priestley 2012 |
| ------------------------------------------------------------------------|
| Permission is hereby granted, free of charge, to any person obtaining a |
| copy of this software and associated documentation files |
| (the "Software"), to deal in the Software without restriction, |
| including without limitation the rights to use, copy, modify, merge, |
| publish, distribute, sublicense, and/or sell copies of the Software, |
| and to permit persons to whom the Software is furnished to do so, |
| subject to the following conditions: |
| ------------------------------------------------------------------------|
| The above copyright notice and this permission notice shall be included |
| in all copies or substantial portions of the Software. |
| ------------------------------------------------------------------------|
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS |
| OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF |
| MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. |
| IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY |
| CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, |
| TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE |
| SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
| -----------------------------------------------------------------------*/
/*
* Allow file access
*/
define('IN_ZINIM_INSTALLER', true);
/*
* $_GET step
*/
if(!isset($_GET['s']) || $_GET['s'] != 1 && $_GET['s'] != 2 && $_GET['s'] != 3 && $_GET['s'] != 4) {
header('Location: ?s=1');
} else {
include('steps/' . $_GET['s'] . '.php');
}
?>
Where's the layout from?Thanks:
I've been cleaning the code up and adding a license in the files, here's my result:
PHP:<?php /*------------------------------------------------------------------------| | Zinim - Copyright (c) Josh Priestley 2012 | | ------------------------------------------------------------------------| | Permission is hereby granted, free of charge, to any person obtaining a | | copy of this software and associated documentation files | | (the "Software"), to deal in the Software without restriction, | | including without limitation the rights to use, copy, modify, merge, | | publish, distribute, sublicense, and/or sell copies of the Software, | | and to permit persons to whom the Software is furnished to do so, | | subject to the following conditions: | | ------------------------------------------------------------------------| | The above copyright notice and this permission notice shall be included | | in all copies or substantial portions of the Software. | | ------------------------------------------------------------------------| | THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | | OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | | MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | | IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY | | CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, | | TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE | | SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | | -----------------------------------------------------------------------*/ /* * Allow file access */ define('IN_ZINIM_INSTALLER', true); /* * $_GET step */ if(!isset($_GET['s']) || $_GET['s'] != 1 && $_GET['s'] != 2 && $_GET['s'] != 3 && $_GET['s'] != 4) { header('Location: ?s=1'); } else { include('steps/' . $_GET['s'] . '.php'); } ?>
I think that i'll stay with my if/else rather than doing a switch case. Much easier in my eyes but it's all down to personal preference. Also, a proper scaled picture:
Next i'm intending on completing the installer and then i'll begin doing the classes.
I think the design is really nice, good job.
