What have I done wrong?

Xenous · Dec 2, 2011

So I'm a noobie at php and I'm trying to some basic input forms, and here's my problem.
Notice: Undefined index: user in C:\xampp\htdocs\index.php on line 13

Notice: Undefined index: pass in C:\xampp\htdocs\index.php on line 14
and my code is

PHP:

<html>
 
<head>
 
<title>
 
Okay lets do this
 
</title>
 
</head>
 
<body>
 
<?php
 
include ('db.php');
 
?>
 
<?php
 
$user = strip_tags(mysql_real_escape_string($_POST['user']));
 
$pass = strip_tags(mysql_real_escape_string($_POST['pass']));
 
mysql_query ("INSERT INTO `users` (`username`, `password`) VALUES ('{$user}', '{$pass}')");
 
?>
 
<form method="post"/>
 
Username: <input type="textbox" name="user" />
 
Password: <input type="textbox" name="pass"/>
 
</form>
 
</body>
 
</html>

so what have I done wrong?

Kieren · Dec 2, 2011

You have PHP and HTML on there? Yet you called it .PHP I doubt it'll trigger the HTML.

Markshall · Dec 2, 2011

For starters, change

Code:

<form method="post"/>

to

Code:

<form method="post">

Also, why are you executing the database query on the page load, you have not included a submit button and anything to handle the button so when you click it, it will reload the page and enter the information into the database, try:

PHP:

<html>
<head>
<title>Okay lets do this</title>
</head>
<body>
<?php
include ('db.php');
if ( isset( $_POST['my_button'] ) )
{
    $user = strip_tags( mysql_real_escape_string( $_POST['user'] ) );
    $pass = strip_tags( mysql_real_escape_string( $_POST['pass'] ) );
    mysql_query( "INSERT INTO `users` (`username`, `password`) VALUES ('{$user}', '{$pass}')" );
}
?>
<form method="post">
Username: <input type="textbox" name="user" /><br />
Password: <input type="textbox" name="pass" /><br /><br />
<input type="submit" name="my_button" value="My Button to do whatever" />
</form>
</body>
</html>

Xenous · Dec 2, 2011

You must be registered for see links

thank you very much I see what I have done wrong and have now learnt a little more thanks :up:

Markshall · Dec 2, 2011

No problems; has it fixed the issue you had?

Also, referring to the '/>' thing. You only need to put /> on HTML tags that don't have an end tag. For example:

<p> does not need '/>' because it has an ending tag which is </p>
<div> does not need '/>' because it has an ending tag which is </div>
<br /> requires '/>' because it does not have an ending tag such as </br>
<input type=" [text|password|email|url|tel] " /> requires '/>' because it does not have an ending tag such as </input>

If you don't understand then I'll try to explain in more depth.
Basically, you only need '/>' on tags that don't have an ending tag.

Xenous · Dec 2, 2011

m0nsta. said:
No problems; has it fixed the issue you had?

Also, referring to the '/>' thing. You only need to put /> on HTML tags that don't have an end tag. For example:

<p> does not need '/>' because it has an ending tag which is </p>
<div> does not need '/>' because it has an ending tag which is </div>
<br /> requires '/>' because it does not have an ending tag such as </br>
<input type=" [text|password|email|url|tel] " /> requires '/>' because it does not have an ending tag such as </input>

If you don't understand then I'll try to explain in more depth.
Basically, you only need '/>' on tags that don't have an ending tag.

ya I partially knew that just I hadnt had a reason to do the html forms (meaning I knew nothing about them) since I had never used php until today thanks anyways you've been a big help

Markshall · Dec 2, 2011

Xeno said:
ya I partially knew that just I hadnt had a reason to do the html forms (meaning I knew nothing about them) since I had never used php until today thanks anyways you've been a big help

You was probably rushing the code and put /> by accident, but anyway - at least you know now.

No worries.

brsy · Dec 20, 2011

Just take your time next time, and I doubt you will make such a simple mistake.

What have I done wrong?

Xenous

o shi

Kieren

The OGz

Markshall

Русский Стандарт

Xenous

o shi

Markshall

Русский Стандарт

Xenous

o shi

Markshall

Русский Стандарт

brsy

nah mang

Users who are viewing this thread

Latest posts

Connect with us

Newest members