Help with PHP Script

chiefqueef · Jun 28, 2014

Hey, Ive got a php image hosting script and when it uploads the image the url it produces is huge

example :

You must be registered for see links

Is there any way I can reduce the size of the links?

thanks

Macemore · Jun 28, 2014

if you're using a random character generator to make the name of the file (which looks right, that or your file names are retarded) then just change how long of a name it generates. You should post your code so people can help you edit it too

chiefqueef · Jun 28, 2014

Macemore said:
if you're using a random character generator to make the name of the file (which looks right, that or your file names are retarded) then just change how long of a name it generates. You should post your code so people can help you edit it too

Code:

<?php
/*
 * Logic here
 */

//check terms
if(!isset($_POST['terms']) OR $_POST['terms'] != 'yes') {
    echo do_error(_('You have to agree to the terms and conditions in order to upload.'));
    exit;
} 

//check files
if(isset($_FILES) AND count($_FILES)) {
   
    $at_least_one_file = FALSE;
    $_SESSION['file_ids'] = array();
   
    for($i = 0; $i <= 4; $i++) {
       
        foreach($_FILES as $file_array) {
           
            if(isset($file_array['name'][$i]) AND $file_array['error'][$i] == 0) {
                   
                //set the file name
                $filename = $file_array['name'][$i];
                $extension = get_file_extension($filename);
                $new_file_name = 'original-' .md5(rand(1000, 9999999) . $filename). '.' . $extension;
               
               
                //first lets check the extension
                if(!extension_check($filename)) 
                {
                    echo do_error(_("Error with file extension no #") . ($i+1));
                    echo do_error(_(sprintf("Extension <strong>%s</strong> not allowed!", $extension)));
                    exit;
                }
               
                //secondly lets check the mime_type
                if(!mimetype_check($file_array['type'][$i])) {
                    echo do_error(_("Error with file mimetype no #") . ($i+1));
                    echo do_error(_(sprintf("MimeType <strong>%s</strong> not allowed!", $file_array['type'][$i])));
                    exit;
                }
               
               
                //thirdly lets check if it's a real image
                $image_size = getimagesize($file_array['tmp_name'][$i]);
                if(!$image_size) {
                    echo do_error(_("Error with file no #") . ($i+1));
                    echo do_error(_("The image is corrupt or not a valid image file!"));
                    exit;
                }
               
                //get upload server
                $srv = get_random_server();
               
                //upload original image
                if($srv->server == "local") {
                    //upload to local server
                    if(!upload_image($file_array['tmp_name'][$i], $new_file_name)) {
                        echo do_error(_("Error with file no #") . ($i+1));
                        echo do_error(_("The image could not be uploaded!"));
                        exit;   
                    }
                }else{
                    //upload to FTP => first to a temporary folder 
                    $upload_dir = APP_PATH . '/image.uploads/temp';
                   
                    if(!move_uploaded_file($file_array['tmp_name'][$i], $upload_dir . '/' . $new_file_name)) {
                        echo do_error(_("Error with file no #") . ($i+1));
                        echo do_error(_("The image could not be uploaded! Check temporary folder image.uploads/temp to be writable"));
                        exit;   
                    }
                   
                    if(upload_to_FTP($new_file_name, $upload_dir . '/' . $new_file_name, $srv->server, $srv->username, $srv->password, $srv->server_path) != 'file_uploaded') {
                        echo do_error(_("The image could not be uploaded on remote FTP Server"));
                        exit;   
                    }
                   
                }
               
                //resize other user option
                $user_option = (int) trim(strip_tags($_POST['user_resize']));
                $user_option = abs(intval($user_option));
               
                if($image_size[0] > 124) {
                    //resize to thumbnail 124x89 for the site
                    //local
                    if($srv->server == "local") {
                        $imageResizeClass->load(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . $new_file_name);
                          $imageResizeClass->resize(124,89);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . str_replace("original", "thumbnail", $new_file_name));
                    }else{
                        //remote FTP => first to temporary
                        $imageResizeClass->load(APP_PATH . '/image.uploads/temp/' . $new_file_name);
                          $imageResizeClass->resize(124,89);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/temp/' . str_replace("original", "thumbnail", $new_file_name));
                       
                        if(upload_to_FTP(str_replace("original", "thumbnail", $new_file_name), APP_PATH . '/image.uploads/temp/' . str_replace("original", "thumbnail", $new_file_name), $srv->server, $srv->username, $srv->password, $srv->server_path) != 'file_uploaded') {
                            echo do_error(_("The image could not be uploaded on remote FTP Server"));
                            exit;   
                        }
                       
                        //remove temp file
                        @unlink(APP_PATH . '/image.uploads/temp/' . str_replace("original", "thumbnail", $new_file_name));
                    }
                }
               
                if($image_size[0] > 640) {
                    //resize to thumbnail 640 in width for the site
                    if($srv->server == "local") {
                        $imageResizeClass->load(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . $new_file_name);
                          $imageResizeClass->resizeToWidth(640);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . str_replace("original", 640, $new_file_name));
                    }else{
                        //remote FTP => first to temporary
                        $imageResizeClass->load(APP_PATH . '/image.uploads/temp/' . $new_file_name);
                          $imageResizeClass->resizeToWidth(640);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/temp/' . str_replace("original", 640, $new_file_name));
                       
                        if(upload_to_FTP(str_replace("original", 640, $new_file_name), APP_PATH . '/image.uploads/temp/' . str_replace("original", 640, $new_file_name), $srv->server, $srv->username, $srv->password, $srv->server_path) != 'file_uploaded') {
                            echo do_error(_("The image could not be uploaded on remote FTP Server"));
                            exit;   
                        }
                       
                        //remove temp file
                        @unlink(APP_PATH . '/image.uploads/temp/' . str_replace("original", 640, $new_file_name));
                    }
                }
               
                //0 means no resize
                if($user_option > 640) {
                    //local
                    if($srv->server == "local") {
                        $imageResizeClass->load(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . $new_file_name);
                          $imageResizeClass->resizeToWidth($user_option);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/' . date('d-m-Y') .'/' . $new_file_name);
                    }else{
                        //remote FTP => first to temporary
                        $imageResizeClass->load(APP_PATH . '/image.uploads/temp/' . $new_file_name);
                          $imageResizeClass->resizeToWidth($user_option);
                          $imageResizeClass->save(APP_PATH . '/image.uploads/temp/' . $new_file_name);
                         
                        if(upload_to_FTP($new_file_name, APP_PATH . '/image.uploads/temp/' . $new_file_name, $srv->server, $srv->username, $srv->password, $srv->server_path) != 'file_uploaded') {
                            echo do_error(_("The image could not be uploaded on remote FTP Server"));
                            exit;   
                        }
                       
                        //remove temp file
                        @unlink(APP_PATH . '/image.uploads/temp/'. $new_file_name);
                    }
                   
                }

                //remove temporary original file
                @unlink(APP_PATH . '/image.uploads/temp/'. $new_file_name);
               
                //insert into database
                $userID = get_user_ID();
                $only_file_name = str_replace("original-", "", $new_file_name);
                $db->query(sprintf("INSERT INTO images 
                                    (image_name, image_user, image_date, image_srv) 
                                    VALUES ('%s', '%d', '%d', '%d')", 
                                    $db->escape($only_file_name), $userID, time(), $srv->serverID));
               
                //success, we have file uploaded! 
                //let's set this for the redirect
                $at_least_one_file = TRUE;
               
                //append this id to the session
                $_SESSION['file_ids'][] = $db->insert_id;
               
            }elseif(!empty($file_array['name'][$i]) AND $file_array['error'][$i] != 0) {
                echo do_error(_("Error with file ") . ($i+1));
            }
        }
       
    }
   
    if(!$at_least_one_file) exit;
   
    //!SHOW VIEW
    echo "show-view";
   
}else{
    echo do_error(_('Please pick up at least one file'));
    exit;
}

Weasel · Jun 28, 2014

Make the filename the current timestamp followed by the users id.

chiefqueef · Jun 28, 2014

H

Sherlock said:
Make the filename the current timestamp followed by the users id.

How would I do that? I tried

Code:

$new_file_name = 'original-' .substr(md5(rand(1000, 9999999)), 0, 6) . $filename . '.' . $extension;

It shortens the filenames but doesnt detect an image when i go to the link plus it shows the link as

You must be registered for see links

n says no image found with that name

Khalil · Jun 28, 2014

PHP:

$new_file_name = time().$id;

dats how

chiefqueef · Jun 28, 2014

Khalil said:
PHP:

$new_file_name = time().$id;

dats how

The users don't have to log-in to upload files so they dont have a user ID

You must be registered for see links

Khalil · Jun 28, 2014

Dolan said:
The users don't have to log-in to upload files so they dont have a user ID

You must be registered for see links

I just showed you how since you said 'How would I do that? I tried'..

chiefqueef · Jun 28, 2014

Khalil said:
I just showed you how since you said 'How would I do that? I tried'..

Thanks anyway bud

Damon · Jun 29, 2014

Search for:

PHP:

$new_file_name = 'original-' .md5(rand(1000, 9999999) . $filename). '.' . $extension;

and replace with

PHP:

$new_file_name = substr(md5(rand()), 0, 10). '.' . $extension;

(You can change '10' to anything you'd like. Thats the amount of characters which will show)
This will make your link shorter..

Help with PHP Script

chiefqueef

gooby pls

Macemore

Circumcised pineapples

chiefqueef

gooby pls

Weasel

👄 I'd intercept me

chiefqueef

gooby pls

Khalil

IDK

chiefqueef

gooby pls

Khalil

IDK

chiefqueef

gooby pls

Damon

Member

Users who are viewing this thread

Latest posts

Connect with us

Newest members