Reply to thread

Message

<blockquote data-quote="Markshall" data-source="post: 32649" data-attributes="member: 1872">Quite possibly the most horrible coding I've ever seen.You have semi-colons and single-quotes in random places for no reason.This should work, I've tidied it up for you:[php]&lt;?php&nbsp; if($assoc['rank'] &lt;5) { &nbsp; &nbsp; exit; }else{&nbsp; &nbsp; $title = $_POST['title']; &nbsp; &nbsp; $shortstory = $_POST['shortstory']; &nbsp; &nbsp; $banner = $_POST['banner']; &nbsp; &nbsp; $content = $_POST['content']; &nbsp; &nbsp; $sent = $_POST['sent']; &nbsp; &nbsp; if($sent != 'yes')&nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; echo '&lt;form name=\'postnews\' action=\'?page=news\' method=\'post\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;alert&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;develop&gt;Creating news is currently broken!&lt;/develop&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Like some other features in this development build of Cores new housekeeping, Creating news is currently broken. If you would like an article &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; posted, then please contant an Administrator with Database access. &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt;&lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Sorry for any inconvenience. &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/alert&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;center&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;b&gt;Title:&lt;/b&gt;&lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;input type=\'text\' name=\'title\' maxlength=\'20\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;b&gt;Short Story:&lt;/b&gt;&lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;input type=\'text\' name=\'shortstory\' maxlength=\'50\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;b&gt;Banner URL (click &lt;a href=&quot;../Public/Images/news/&quot; target=&quot;_BLANK&quot;&gt;here&lt;/a&gt;):&lt;/b&gt;&lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;input type=\'text\' name=\'banner\'&nbsp; maxlength=\'500\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;b&gt;Full Story:&lt;/b&gt;&lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;textarea class=&quot;ckeditor&quot; cols=30 rows=7 name=\'content\'&gt;&lt;/textarea&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;br&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;input type=\'submit\' value=\'Post\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &lt;input type=\'hidden\' name=\'sent\' value=\'yes\'&gt; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/form&gt;&lt;/p&gt;'; &nbsp; &nbsp; }&nbsp; &nbsp; else &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; $time = time();&nbsp; &nbsp; &nbsp; &nbsp; $query = mysql_query(&quot;INSERT INTO cms_news (`title`, `shortstory`, `longstory`, `author`, `published`, `image`, `campaign`, `campaignimg`) VALUES ('&quot;.$title .&quot;', '&quot;.$shortstory .&quot;', '&quot;.$content .&quot;', '1', '&quot;.$time.&quot;', '&quot;.$banner .&quot;', '0', '');&quot;); &nbsp; &nbsp; &nbsp; &nbsp; echo &quot;&lt;center&gt;&lt;h1&gt;Article posted!&lt;/h1&gt;&lt;/center&gt;&quot;; &nbsp; &nbsp; }}?&gt;[/php]</blockquote>

[QUOTE="Markshall, post: 32649, member: 1872"] Quite possibly the most horrible coding I've ever seen. You have semi-colons and single-quotes in random places for no reason. This should work, I've tidied it up for you: [php]<?php if($assoc['rank'] <5) { exit; } else { $title = $_POST['title']; $shortstory = $_POST['shortstory']; $banner = $_POST['banner']; $content = $_POST['content']; $sent = $_POST['sent']; if($sent != 'yes') { echo '<form name=\'postnews\' action=\'?page=news\' method=\'post\'> <alert> <develop>Creating news is currently broken!</develop> Like some other features in this development build of Cores new housekeeping, Creating news is currently broken. If you would like an article posted, then please contant an Administrator with Database access. Sorry for any inconvenience. </alert> <center> Title: <input type=\'text\' name=\'title\' maxlength=\'20\'> Short Story: <input type=\'text\' name=\'shortstory\' maxlength=\'50\'> Banner URL (click <a href="../Public/Images/news/" target="_BLANK">here</a>): <input type=\'text\' name=\'banner\' maxlength=\'500\'> Full Story: <textarea class="ckeditor" cols=30 rows=7 name=\'content\'></textarea> <input type=\'submit\' value=\'Post\'> <input type=\'hidden\' name=\'sent\' value=\'yes\'> </form>'; } else { $time = time(); $query = mysql_query("INSERT INTO cms_news (`title`, `shortstory`, `longstory`, `author`, `published`, `image`, `campaign`, `campaignimg`) VALUES ('".$title ."', '".$shortstory ."', '".$content ."', '1', '".$time."', '".$banner ."', '0', '');"); echo "<center><h1>Article posted!</h1></center>"; } } ?>[/php] [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members