Reply to thread

Message

<blockquote data-quote="TheGeneral" data-source="post: 471641" data-attributes="member: 73182">Technically there is no difference. With a scoped using you've got a more control over when the object is disposed. With an non scoped using statement its at the end of the method. If thats supposed to be the lifetime of your disosable object then go with the new style.Non scoped using statements also save on horizontal space as there is one less indentation per scoped using. Imaging having 3 scoped usings, it saves 12 characters (depending on your indentation settings) in width.[automerge]1637502725[/automerge]Also your message parsing could be simplified to something like:[CODE=csharp]TargetIds = Enumerable.Range(0, message.ReadUint()).Select(_ =&gt; message.ReadUint()).ToList();[/CODE][automerge]1637502796[/automerge]Why are you using a dedicated [ICODE]Parse(IClientMessage)[/ICODE] method while initializing the object from its constructor is pointless atm? How about passing the [ICODE]IClientMessage[/ICODE] object to the constructor instead?</blockquote>

[QUOTE="TheGeneral, post: 471641, member: 73182"] Technically there is no difference. With a scoped using you've got a more control over when the object is disposed. With an non scoped using statement its at the end of the method. If thats supposed to be the lifetime of your disosable object then go with the new style. Non scoped using statements also save on horizontal space as there is one less indentation per scoped using. Imaging having 3 scoped usings, it saves 12 characters (depending on your indentation settings) in width. [automerge]1637502725[/automerge] Also your message parsing could be simplified to something like: [CODE=csharp]TargetIds = Enumerable.Range(0, message.ReadUint()).Select(_ => message.ReadUint()).ToList();[/CODE] [automerge]1637502796[/automerge] Why are you using a dedicated [ICODE]Parse(IClientMessage)[/ICODE] method while initializing the object from its constructor is pointless atm? How about passing the [ICODE]IClientMessage[/ICODE] object to the constructor instead? [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members