Reply to thread

Message

<blockquote data-quote="Sledmore" data-source="post: 386394" data-attributes="member: 591">I'm curious why you have another method in there when it isn't needed? The disconnections are due to invalid packet structure.The issue here is one of the packets are wrong - the accept &amp; confirm have the same headers.TradingAcceptMessageComposerTradingConfirmedMessageComposerShould be the same packet ID value. So one of those is wrong, simply test both to see which is correct.As for your TradingUpdateComposer that is very wrong, you should never break/return mid structure.[PHP]if (Trade.Users.Count() &lt; 2)return;[/PHP]Needs removing for a start.[PHP]&nbsp;&nbsp; class TradingUpdateComposer : ServerPacket&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; public TradingUpdateComposer(Trade Trade)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; : base(ServerPacketHeader.TradingUpdateMessageComposer)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (TradeUser User in Trade.Users.ToList())&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(User.GetClient().GetHabbo().Id);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(User.OfferedItems.Count);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (Item Item in User.OfferedItems.ToList())&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(Item.Id);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteString(Item.GetBaseItem().Type.ToString().ToLower());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(Item.Id);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(Item.Data.SpriteId);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);//Not sure.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteBoolean(true);//Stackable&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteString(&quot;&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (Item.GetBaseItem().Type == 's')&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(User.OfferedItems.Count);//Item Count&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.WriteInteger(0);//Value of the items.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }[/PHP]Is what it should be.</blockquote>

[QUOTE="Sledmore, post: 386394, member: 591"] I'm curious why you have another method in there when it isn't needed? The disconnections are due to invalid packet structure. The issue here is one of the packets are wrong - the accept & confirm have the same headers. TradingAcceptMessageComposer TradingConfirmedMessageComposer Should be the same packet ID value. So one of those is wrong, simply test both to see which is correct. As for your TradingUpdateComposer that is very wrong, you should never break/return mid structure. [PHP] if (Trade.Users.Count() < 2) return;[/PHP] Needs removing for a start. [PHP] class TradingUpdateComposer : ServerPacket { public TradingUpdateComposer(Trade Trade) : base(ServerPacketHeader.TradingUpdateMessageComposer) { foreach (TradeUser User in Trade.Users.ToList()) { base.WriteInteger(User.GetClient().GetHabbo().Id); base.WriteInteger(User.OfferedItems.Count); foreach (Item Item in User.OfferedItems.ToList()) { base.WriteInteger(Item.Id); base.WriteString(Item.GetBaseItem().Type.ToString().ToLower()); base.WriteInteger(Item.Id); base.WriteInteger(Item.Data.SpriteId); base.WriteInteger(0);//Not sure. base.WriteBoolean(true);//Stackable base.WriteInteger(0); base.WriteString(""); base.WriteInteger(0); base.WriteInteger(0); base.WriteInteger(0); if (Item.GetBaseItem().Type == 's') base.WriteInteger(0); } base.WriteInteger(User.OfferedItems.Count);//Item Count base.WriteInteger(0);//Value of the items. } } }[/PHP] Is what it should be. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members