PlusEMU trading

Status
Not open for further replies.
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
So recently, I noticed that trading doesn't work on my PlusEMU that is updated.

When you go to trade a user, you can both confirm the trade, but then it will say "Modify Trade" and wont do anything even if you click it.
You must be registered for see images attach


On the other end of the trade, it does the same. But, you cannot see what the person is trading unless you hover over the item.
You must be registered for see images attach
 
Sort by date Sort by votes
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Looks like a packet issue, if I remember rightly there is two trading headers with the same packet IDs.

TradingAcceptMessageComposer
TradingConfirmedMessageComposer

Must have the same packet IDs.
 
Upvote 0 Downvote
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
Sledmore said:
Looks like a packet issue, if I remember rightly there is two trading headers with the same packet IDs.

TradingAcceptMessageComposer
TradingConfirmedMessageComposer

Must have the same packet IDs.
Click to expand...
They are the exact same.
Code: 
public const int TradingConfirmedMessageComposer = 2457; // PRODUCTION-201610052203-260805057

public const int TradingAcceptMessageComposer = 2457; // PRODUCTION-201610052203-260805057
 
Upvote 0 Downvote
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
Sledmore said:
Not too sure in that case. Might be another trade related packet.
Click to expand...
Wait, would it be incoming packets? Because they are different in the incoming.
Code: 
public const int TradingAcceptMessageEvent = 2526; // PRODUCTION-201610052203-260805057
public const int TradingConfirmMessageEvent = 1987; // PRODUCTION-201610052203-260805057
 
Upvote 0 Downvote
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Blasteh said:
Wait, would it be incoming packets? Because they are different in the incoming.
Code: 
public const int TradingAcceptMessageEvent = 2526; // PRODUCTION-201610052203-260805057
public const int TradingConfirmMessageEvent = 1987; // PRODUCTION-201610052203-260805057
Click to expand...

Those two are correct, just checked them (used my headers to update to yours). Paste the rest of your trading ones and I'll give them a check.
 
Upvote 0 Downvote
Core

Core

Member
Nov 10, 2016
356
138
Your packet headers are wrong. Manually update them:p auto updater gets wrong one or make it get the second reference; not the first
 
Upvote 0 Downvote
JayC

JayC

Always Learning
Aug 8, 2013
5,504
1,401
Code: 
using System;
using System.Linq;
using System.Text;
using System.Collections.Generic;
using Plus.HabboHotel.Rooms.Trading;
using Plus.HabboHotel.Items;

namespace Plus.Communication.Packets.Outgoing.Inventory.Trading
{
class TradingUpdateComposer : ServerPacket
{
public TradingUpdateComposer(Trade Trade) : base(ServerPacketHeader.TradingUpdateMessageComposer)
{

if (Trade.Users.Count() < 2)
return;

var User1 = Trade.Users.First();
var User2 = Trade.Users.Last();

base.WriteInteger(User1.GetClient().GetHabbo().Id);
SerializeUserItems(User1);

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(1);

SerializeUserItems(User2);

base.WriteInteger(0);
base.WriteInteger(0);

/*base.WriteInteger(User.GetClient().GetHabbo().Id);
base.WriteInteger(User.OfferedItems.Count);

foreach (Item Item in User.OfferedItems.ToList())
{
base.WriteInteger(Item.Id);
base.WriteString(Item.GetBaseItem().Type.ToString().ToLower());
base.WriteInteger(Item.Id);
base.WriteInteger(Item.Data.SpriteId);
base.WriteInteger(0);//Not sure.
if (Item.LimitedNo > 0)
{
base.WriteBoolean(false);//Stackable
base.WriteInteger(256);
base.WriteString("");
base.WriteInteger(Item.LimitedNo);
base.WriteInteger(Item.LimitedTot);
}
else
{
base.WriteBoolean(true);//Stackable
base.WriteInteger(0);
base.WriteString("");
}

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(0);

if (Item.GetBaseItem().Type == 's')
base.WriteInteger(0);

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(-1);*/
}
private void SerializeUserItems(TradeUser User)
{
base.WriteInteger(User.OfferedItems.Count);//While
foreach (Item Item in User.OfferedItems.ToList())
{
base.WriteInteger(Item.Id);
base.WriteString(Item.Data.Type.ToString().ToUpper());
base.WriteInteger(Item.Id);
base.WriteInteger(Item.Data.SpriteId);
base.WriteInteger(1);
base.WriteBoolean(true);

//Func called _SafeStr_15990
base.WriteInteger(0);
base.WriteString("");

//end Func called
base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(0);
if (Item.Data.Type.ToString().ToUpper() == "S")
base.WriteInteger(0);
}
//End of while
}
}
}
 
Upvote 0 Downvote
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
Sledmore said:
Those two are correct, just checked them (used my headers to update to yours). Paste the rest of your trading ones and I'll give them a check.
Click to expand...
Outgoing:
You must be registered for see links

Incoming:
You must be registered for see links


JayCustom said:
Code: 
using System;
using System.Linq;
using System.Text;
using System.Collections.Generic;
using Plus.HabboHotel.Rooms.Trading;
using Plus.HabboHotel.Items;

namespace Plus.Communication.Packets.Outgoing.Inventory.Trading
{
class TradingUpdateComposer : ServerPacket
{
public TradingUpdateComposer(Trade Trade) : base(ServerPacketHeader.TradingUpdateMessageComposer)
{

if (Trade.Users.Count() < 2)
return;

var User1 = Trade.Users.First();
var User2 = Trade.Users.Last();

base.WriteInteger(User1.GetClient().GetHabbo().Id);
SerializeUserItems(User1);

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(1);

SerializeUserItems(User2);

base.WriteInteger(0);
base.WriteInteger(0);

/*base.WriteInteger(User.GetClient().GetHabbo().Id);
base.WriteInteger(User.OfferedItems.Count);

foreach (Item Item in User.OfferedItems.ToList())
{
base.WriteInteger(Item.Id);
base.WriteString(Item.GetBaseItem().Type.ToString().ToLower());
base.WriteInteger(Item.Id);
base.WriteInteger(Item.Data.SpriteId);
base.WriteInteger(0);//Not sure.
if (Item.LimitedNo > 0)
{
base.WriteBoolean(false);//Stackable
base.WriteInteger(256);
base.WriteString("");
base.WriteInteger(Item.LimitedNo);
base.WriteInteger(Item.LimitedTot);
}
else
{
base.WriteBoolean(true);//Stackable
base.WriteInteger(0);
base.WriteString("");
}

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(0);

if (Item.GetBaseItem().Type == 's')
base.WriteInteger(0);

base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(-1);*/
}
private void SerializeUserItems(TradeUser User)
{
base.WriteInteger(User.OfferedItems.Count);//While
foreach (Item Item in User.OfferedItems.ToList())
{
base.WriteInteger(Item.Id);
base.WriteString(Item.Data.Type.ToString().ToUpper());
base.WriteInteger(Item.Id);
base.WriteInteger(Item.Data.SpriteId);
base.WriteInteger(1);
base.WriteBoolean(true);

//Func called _SafeStr_15990
base.WriteInteger(0);
base.WriteString("");

//end Func called
base.WriteInteger(0);
base.WriteInteger(0);
base.WriteInteger(0);
if (Item.Data.Type.ToString().ToUpper() == "S")
base.WriteInteger(0);
}
//End of while
}
}
}
Click to expand...
Didn't work.
 
Upvote 0 Downvote
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Blasteh said:
So what you're saying is it's the wrong packet header?
Click to expand...

Which is what I said in my earlier posts. I've found the wrong one, I've not looked further - but this one is 100% wrong.

PHP: 
public const int TradingFinishMessageComposer = 1500; // PRODUCTION-201610052203-260805057

It should be:

PHP: 
public const int TradingFinishMessageComposer = 3056; // PRODUCTION-201610052203-260805057

Fun fact, if you have one wrong chances are you have a couple more wrong - which may not be an issue now, but could be in the future.
 
Upvote 0 Downvote
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
Sledmore said:
Which is what I said in my earlier posts. I've found the wrong one, I've not looked further - but this one is 100% wrong.

PHP: 
public const int TradingFinishMessageComposer = 1500; // PRODUCTION-201610052203-260805057

It should be:

PHP: 
public const int TradingFinishMessageComposer = 3056; // PRODUCTION-201610052203-260805057

Fun fact, if you have one wrong chances are you have a couple more wrong - which may not be an issue now, but could be in the future.
Click to expand...
Any idea what headers could be causing the issue? I don't really wanna go through every single one on the list..

But, I used the AHU from RZ to check a packet. The two packets where you said that should be the same, come up with a different ID then what I showed you.
You must be registered for see images attach
 
Upvote 0 Downvote
JayC

JayC

Always Learning
Aug 8, 2013
5,504
1,401
Server Packet Header
Code: 
public const int TradingFinishMessageComposer = 1976;

Client Packer Header
Code: 
public const int TradingAcceptMessageEvent = 2937;
Code: 
public const int TradingConfirmMessageEvent = 1215;

This is the production I am currently on - I believe its 08

These might be wrong for your prod :( But I hope it helps <3
 
Upvote 0 Downvote
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Blasteh said:
Any idea what headers could be causing the issue? I don't really wanna go through every single one on the list..

But, I used the AHU from RZ to check a packet. The two packets where you said that should be the same, come up with a different ID then what I showed you.
You must be registered for see images attach
Click to expand...

Is it still happening? Did you change the header ID I said to above?
 
JayCustom said:
Server Packet Header
Code: 
public const int TradingFinishMessageComposer = 1976;

Client Packer Header
Code: 
public const int TradingAcceptMessageEvent = 2937;
Code: 
public const int TradingConfirmMessageEvent = 1215;

This is the production I am currently on - I believe its 08

These might be wrong for your prod :( But I hope it helps <3
Click to expand...

Will not work for him. As different revision.
 
Blasteh said:
But, I used the AHU from RZ to check a packet. The two packets where you said that should be the same, come up with a different ID then what I showed you.
You must be registered for see images attach
Click to expand...

Feel free to try that, however I'm pretty sure that they're right. You need to change the TradingFinishMessageComposer.
 
Upvote 0 Downvote
Blasteh

Blasteh

big tits
Apr 3, 2013
1,156
521
Sledmore said:
Is it still happening? Did you change the header ID I said to above?
 


Will not work for him. As different revision.
 


Feel free to try that, however I'm pretty sure that they're right. You need to change the TradingFinishMessageComposer.
Click to expand...
Yes, I have changed it, but it still does not seem to work :(
 
Upvote 0 Downvote
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Okay, found another. Try this?

PHP: 
public const int TradingCompleteMessageComposer = 648; // PRODUCTION-201610052203-260805057
 
Upvote 0 Downvote
Sledmore

Sledmore

Chaturbate Livestreamer
Staff member
FindRetros Moderator
Jul 24, 2010
5,198
3,914
Blasteh said:
Hey, it worked! Thanks for your help Sledmore. Helpful and efficient as always.
Click to expand...

No problem! Just be cautious about using packet updaters - I made my own, and even then sometimes it can throw me the wrong result out.

Also, I replied to your RevCMS news comments thread with some code - not sure if you've seen it yet.

Thread closed.
 
Upvote 0 Downvote
Status
Not open for further replies.

Users who are viewing this thread

Total: 2 (members: 0, guests: 2)
☀️  Switch to Light Theme

Latest posts

Top