Reply to thread

Message

<blockquote data-quote="Markshall" data-source="post: 221522" data-attributes="member: 1872">I can't help but think your config function could've been simplified a lot more.&nbsp;This is what you have:[PHP]public function config($type, $height = &quot;0&quot;, $width = &quot;0&quot;) {&nbsp; &nbsp; $this-&gt;height = $height;&nbsp; &nbsp; $this-&gt;width&nbsp; = $width;&nbsp;&nbsp; &nbsp; switch( $type ) {&nbsp; &nbsp; &nbsp; &nbsp; case &quot;png&quot;:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; $this-&gt;mime = 'png';&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return header('Content-Type: image/png');&nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; case &quot;gif&quot;:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; $this-&gt;mime = 'gif';&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return header('Content-Type: image/gif');&nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; case &quot;jpeg&quot;:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; $this-&gt;mime = 'jpeg';&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return header('Content-Type: image/jpeg');&nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; }}[/PHP]&nbsp;..and this is what you could have:[PHP]public function config($type, $height = 0, $width = 0) {&nbsp; &nbsp; $this-&gt;height = $height;&nbsp; &nbsp; $this-&gt;width&nbsp; = $width;&nbsp;&nbsp; &nbsp; &nbsp; if (in_array(strtolower($type), array(&quot;png&quot;,&quot;gif&quot;,&quot;jpeg&quot;))) {&nbsp; &nbsp; &nbsp; &nbsp; $this-&gt;mime = strtolower($type);&nbsp; &nbsp; &nbsp; &nbsp; return header('Content-type: image/' . strtolower($type));&nbsp; &nbsp; }}[/PHP]&nbsp;But yeah, pretty cool, nice work.</blockquote>

[QUOTE="Markshall, post: 221522, member: 1872"] I can't help but think your config function could've been simplified a lot more. This is what you have: [PHP]public function config($type, $height = "0", $width = "0") { $this->height = $height; $this->width = $width; switch( $type ) { case "png": $this->mime = 'png'; return header('Content-Type: image/png'); break; case "gif": $this->mime = 'gif'; return header('Content-Type: image/gif'); break; case "jpeg": $this->mime = 'jpeg'; return header('Content-Type: image/jpeg'); break; } }[/PHP] ..and this is what you could have: [PHP]public function config($type, $height = 0, $width = 0) { $this->height = $height; $this->width = $width; if (in_array(strtolower($type), array("png","gif","jpeg"))) { $this->mime = strtolower($type); return header('Content-type: image/' . strtolower($type)); } }[/PHP] But yeah, pretty cool, nice work. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members