Reply to thread

Message

<blockquote data-quote="Raizer" data-source="post: 466514" data-attributes="member: 84739">Good luck with your project.There are few things I don't like programwise. For example your rconServices, because everything is already builded in Arcturus so why you create for each rcon a function? For example you can do[code]Api::execute('setrank', ['user_id' =&gt; 1' rank' =&gt; 1]);[/code][code]$data = json_encode(array('key' =&gt; $param, 'data' =&gt; $data));if(socket_write($socket, $data, strlen($data)) === false){&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;}[/code]And also, why did you choose to make envoirement file for configurable for everything? In my eyes env file is for the environment not for configurable stuff like credits. And also why you do the validation stuff in your actions? That is not how it should be. Also you replaced services for actions? I'd never programmed in laravel but my prefer is Ares. If you want to see how they did the logical stuff, it can help you in progress for this.<a href="https://gitlab.com/ares-team/ares-backend" target="_blank">Ares / Ares-Backend · GitLab</a>Good luck with your project!</blockquote>

[QUOTE="Raizer, post: 466514, member: 84739"] Good luck with your project. There are few things I don't like programwise. For example your rconServices, because everything is already builded in Arcturus so why you create for each rcon a function? For example you can do [code] Api::execute('setrank', ['user_id' => 1' rank' => 1]); [/code] [code] $data = json_encode(array('key' => $param, 'data' => $data)); if(socket_write($socket, $data, strlen($data)) === false){ return; } [/code] And also, why did you choose to make envoirement file for configurable for everything? In my eyes env file is for the environment not for configurable stuff like credits. And also why you do the validation stuff in your actions? That is not how it should be. Also you replaced services for actions? I'd never programmed in laravel but my prefer is Ares. If you want to see how they did the logical stuff, it can help you in progress for this. [URL='https://gitlab.com/ares-team/ares-backend']Ares / Ares-Backend · GitLab[/URL] Good luck with your project! [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members