Reply to thread

Message

<blockquote data-quote="Sledmore" data-source="post: 232874" data-attributes="member: 591">Just taking a look through it now, and a lot of statistics in there could just be used with cache and not updated via the database everytime. Such as the arrest command, it uses about 10 different querys. The beds could be set as `action_points` and could be cached on reboot or simply coded static.I've also had a look at the timers, and they could be done in one loop, using only one thread - it would be much suitable than a thread per user.There is also a mix of system timers and system threads, use one only. It depends on which one to use as it depends to how small the intervals are. I'd suggest two threads (its really all RP needs; a one minute timer and a 5 second timer).An improvement to simple stuff such as no fight-zones, no taxizones etc could all have a cached value rather than being declared in the description. On the same topic the bot AI could also be massively improved, such as a bot team not being declared by its name or motto. Their health and other statisics could also be cached as a bot isn't used as much as a user you can save a bots statistics when the bot is disposed or the room is unloaded.There is some other simple things like a bots position being updated as its added to a room (why?).One final big thing that stood out to m was the manager commands, there is a lot of data being grabbed, when the query can be limited, only take what is needed. But the job roles could ALL be cached.Just my little input, but nice share.</blockquote>

[QUOTE="Sledmore, post: 232874, member: 591"] Just taking a look through it now, and a lot of statistics in there could just be used with cache and not updated via the database everytime. Such as the arrest command, it uses about 10 different querys. The beds could be set as `action_points` and could be cached on reboot or simply coded static. I've also had a look at the timers, and they could be done in one loop, using only one thread - it would be much suitable than a thread per user. There is also a mix of system timers and system threads, use one only. It depends on which one to use as it depends to how small the intervals are. I'd suggest two threads (its really all RP needs; a one minute timer and a 5 second timer). An improvement to simple stuff such as no fight-zones, no taxizones etc could all have a cached value rather than being declared in the description. On the same topic the bot AI could also be massively improved, such as a bot team not being declared by its name or motto. Their health and other statisics could also be cached as a bot isn't used as much as a user you can save a bots statistics when the bot is disposed or the room is unloaded. There is some other simple things like a bots position being updated as its added to a room (why?). One final big thing that stood out to m was the manager commands, there is a lot of data being grabbed, when the query can be limited, only take what is needed. But the job roles could ALL be cached. Just my little input, but nice share. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members