Reply to thread

Message

<blockquote data-quote="Synapse" data-source="post: 431091" data-attributes="member: 13644">EDIT: Overthought it, wasn't the code: for anyone else having issue the error is you need to make your header location: <a href="https://findretros.com/servers/YOURHOTEL/vote?minimal=1&amp;return=1" target="_blank">https://findretros.com/servers/YOURHOTEL/vote?minimal=1&amp;return=1</a> (the old API system doesn't pass the return parameter to the new system)It's looking for voted, and you're giving it novote, thinking you've not voted.ALSO after further review of your code:You're immediately&nbsp; closing the bracket for the voted if clause, and saying already to do that. They're probably returning to your site with ?voted or ?novote, triggering that which is saying if they have that DON'T run the code below it. Which is the opposite of what you're doing. Actually the more I read your code, the less I understand why it doesn't return a 500.After rewriting the code, I realized what you were trying to achieve (I think) and decided to clean it up a tad:[code]&lt;?phpif(!isset($_GET['voted']) || $_SESSION['user']['last_vote'] &lt; timestamp()) {&nbsp; &nbsp; $userip = &quot;{$_SERVER['HTTP_CF_CONNECTING_IP']}&quot;;&nbsp; &nbsp; $current_url = substr($_SERVER[&quot;SCRIPT_NAME&quot;],strrpos($_SERVER[&quot;SCRIPT_NAME&quot;],&quot;/&quot;)+1);&nbsp; &nbsp; $url = 'http://votingapi.com/validate.php?user=Lucid&amp;ip=' . $userip;&nbsp; &nbsp; $context = stream_context_create(array('http' =&gt; array('timeout' =&gt; 1)));&nbsp; &nbsp; $data = @file_get_contents($url, 1, $context);&nbsp; &nbsp; if(!$data || !is_numeric($data)) {&nbsp; &nbsp; &nbsp; &nbsp; return &quot;Error&quot;;&nbsp; &nbsp; }&nbsp; &nbsp; elseif($data &gt; 2) {&nbsp; &nbsp; &nbsp;&nbsp; header (&quot;Location: http://votingapi.com/vote.php?username=Lucid&amp;api=https:!!lucidhotel.pw!client?novote&quot;);&nbsp; &nbsp; }&nbsp; &nbsp; else {&nbsp; &nbsp; &nbsp; &nbsp; // Wait an hour before you check again (reduces server load, increases load speed)&nbsp; &nbsp; &nbsp; &nbsp; $_SESSION['user']['last_vote'] = timestamp()+3600;&nbsp; &nbsp; }}else {&nbsp; &nbsp; header (&quot;Location: http://votingapi.com/vote.php?username=Lucid&amp;api=https:!!lucidhotel.pw!client?novote&quot;);}[/code]This code is untested, and may not do EXACTLY what you want it to do (your code was somewhat difficult to understand). But with minor modifications this should work. Also you need to match the $_GET['voted'] with the ?voted, also in most CMS this isn't passed in the URL due to url rewrite, so you have to make a URL rewrite for it (as most hotels do) to youthotel.com/client/voted instead of yourhotel.com/client?votedBasically the code I wrote, if someone tries to pass ?voted to your server, it checks the votingapi if they have really voted. If not, it redirects them to vote. If thevoting api returns an error, it lets them on (not their fault, they shouldn't be punished!) If there is no voted parameter, it sends them to the voting api automatically, without other logic. If data is not bigger than 1 or 2, sends them to the voting API. If not it does nothing.</blockquote>

[QUOTE="Synapse, post: 431091, member: 13644"] EDIT: Overthought it, wasn't the code: for anyone else having issue the error is you need to make your header location: [URL]https://findretros.com/servers/YOURHOTEL/vote?minimal=1&return=1[/URL] (the old API system doesn't pass the return parameter to the new system) It's looking for voted, and you're giving it novote, thinking you've not voted. ALSO after further review of your code: You're immediately closing the bracket for the voted if clause, and saying already to do that. They're probably returning to your site with ?voted or ?novote, triggering that which is saying if they have that DON'T run the code below it. Which is the opposite of what you're doing. Actually the more I read your code, the less I understand why it doesn't return a 500. After rewriting the code, I realized what you were trying to achieve (I think) and decided to clean it up a tad: [code] <?php if(!isset($_GET['voted']) || $_SESSION['user']['last_vote'] < timestamp()) { $userip = "{$_SERVER['HTTP_CF_CONNECTING_IP']}"; $current_url = substr($_SERVER["SCRIPT_NAME"],strrpos($_SERVER["SCRIPT_NAME"],"/")+1); $url = 'http://votingapi.com/validate.php?user=Lucid&ip=' . $userip; $context = stream_context_create(array('http' => array('timeout' => 1))); $data = @file_get_contents($url, 1, $context); if(!$data || !is_numeric($data)) { return "Error"; } elseif($data > 2) { header ("Location: http://votingapi.com/vote.php?username=Lucid&api=https:!!lucidhotel.pw!client?novote"); } else { // Wait an hour before you check again (reduces server load, increases load speed) $_SESSION['user']['last_vote'] = timestamp()+3600; } } else { header ("Location: http://votingapi.com/vote.php?username=Lucid&api=https:!!lucidhotel.pw!client?novote"); } [/code] This code is untested, and may not do EXACTLY what you want it to do (your code was somewhat difficult to understand). But with minor modifications this should work. Also you need to match the $_GET['voted'] with the ?voted, also in most CMS this isn't passed in the URL due to url rewrite, so you have to make a URL rewrite for it (as most hotels do) to youthotel.com/client/voted instead of yourhotel.com/client?voted Basically the code I wrote, if someone tries to pass ?voted to your server, it checks the votingapi if they have really voted. If not, it redirects them to vote. If thevoting api returns an error, it lets them on (not their fault, they shouldn't be punished!) If there is no voted parameter, it sends them to the voting api automatically, without other logic. If data is not bigger than 1 or 2, sends them to the voting API. If not it does nothing. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members