Menu
Forums
All threads
Latest threads
New posts
Trending threads
New posts
Search forums
Trending
What's new
New posts
New profile posts
Latest activity
Members
Current visitors
New profile posts
Search profile posts
Upgrades
Log in
Register
What's new
Search
Search
Search titles only
By:
All threads
Latest threads
New posts
Trending threads
New posts
Search forums
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
Server Development
Habbo Retros
Habbo Releases
Cascade - C# 6.0 - Updated Regularly
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Jaden" data-source="post: 388799" data-attributes="member: 51705"><p><strong>Noticed a few things while reviewing the source code</strong></p><ul> <li data-xf-list-type="ul">Using a MySQL pool is redundant instead of just using a 1 connection for such a small, single-threaded program.</li> <li data-xf-list-type="ul">Using a MySQL connection in general is redundant, and resource hogging to the server, suggest you take a look at IPC via shared pipes, or LAN connections... or just connect to the MUS server that the emulator established for no reason (barely utilized), then your idea of remote monitoring works simple.</li> <li data-xf-list-type="ul">You throw an argument exception in <strong>DatabaseSettings.cs</strong> which goes unhandled by the code that calls the function (you should try a different approach at error reporting).</li> <li data-xf-list-type="ul">Usage of "global" which is fine i guess since this is a simple, single-threaded application but just pointing that out. Read more: <a href="http://stackoverflow.com/questions/1263954/is-global-constants-an-anti-pattern" target="_blank">http://stackoverflow.com/questions/1263954/is-global-constants-an-anti-pattern</a></li> <li data-xf-list-type="ul">In<strong> CascadeProcess.cs </strong>the usage of the <strong>System.Timers.Timer</strong> class is "redundant" (could be substituted for better performance/use of resources) since your program seems to be (should) be single-threaded. You don't need a thread-safe timer. Finally, that timer should never lag.</li> <li data-xf-list-type="ul"><strong>CascadeProcess.cs#L238</strong> Your query should be more specific than that, rather than using "SELECT *"</li> <li data-xf-list-type="ul"><strong>Utility.cs </strong>you establish WebClient to check if the website works, just to establish <strong>ANOTHER </strong>WebClient to grab the source of the web page. Just use 1 WebClient.</li> <li data-xf-list-type="ul"><strong>CascadeUpdater.cs </strong>just check for updates when the application starts, a timer is not needed.</li> </ul><p>Getting bored with reviewing the source but I'll keep updating. Hopefully you take my criticism into consideration no matter how pessimistic (coughs, *****<em> ********</em>) it may seem as you improve/add to the source code.</p></blockquote><p></p>
[QUOTE="Jaden, post: 388799, member: 51705"] [B]Noticed a few things while reviewing the source code[/B] [LIST] [*]Using a MySQL pool is redundant instead of just using a 1 connection for such a small, single-threaded program. [*]Using a MySQL connection in general is redundant, and resource hogging to the server, suggest you take a look at IPC via shared pipes, or LAN connections... or just connect to the MUS server that the emulator established for no reason (barely utilized), then your idea of remote monitoring works simple. [*]You throw an argument exception in [B]DatabaseSettings.cs[/B] which goes unhandled by the code that calls the function (you should try a different approach at error reporting). [*]Usage of "global" which is fine i guess since this is a simple, single-threaded application but just pointing that out. Read more: [URL]http://stackoverflow.com/questions/1263954/is-global-constants-an-anti-pattern[/URL] [*]In[B] CascadeProcess.cs [/B]the usage of the [B]System.Timers.Timer[/B] class is "redundant" (could be substituted for better performance/use of resources) since your program seems to be (should) be single-threaded. You don't need a thread-safe timer. Finally, that timer should never lag. [*][B]CascadeProcess.cs#L238[/B] Your query should be more specific than that, rather than using "SELECT *" [*][B]Utility.cs [/B]you establish WebClient to check if the website works, just to establish [B]ANOTHER [/B]WebClient to grab the source of the web page. Just use 1 WebClient. [*][B]CascadeUpdater.cs [/B]just check for updates when the application starts, a timer is not needed. [/LIST] Getting bored with reviewing the source but I'll keep updating. Hopefully you take my criticism into consideration no matter how pessimistic (coughs, *****[I] ********[/I]) it may seem as you improve/add to the source code. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
Server Development
Habbo Retros
Habbo Releases
Cascade - C# 6.0 - Updated Regularly
Top