Redirect Loop

[Berk]

Hey
So I tried to implement voting to my hotel and I get ERR_TOO_MANY_REDIRECTS error. On top of client, I include vote.php and vote.php contains:

<?php

require_once 'findretros_config.php';
require_once 'findretros.php';

$FindRetros = new FindRetros();

if($FindRetros->hasClientVoted()) {

    header('Location:/client');

}else{

    // echo 'You have yet to vote!';

    $FindRetros->redirectClientToVote();

}

findretros_config.php

<?php
$_CONFIG = array(
    /* What is "username" of your page on FindRetros? */
   
    'pagename' => 'HablitHotel1',
    /* How many seconds should it take to try and reach FindRetros if it's down? */
    'timeout'  => 2,
    /* Are you using CloudFlare? If so, set this to true. */
    'cloudflare' => true,
    /* Incase FindRetros.com has a new domain, change it below. */
    'api' => 'https://findretros.com/'
);

 

[RastaLulz]

try this in your forcevote.php

<?php
if(isset($_GET['voted'])) {
}
else {
$userip = "{$_SERVER['REMOTE_ADDR']}";
$current_url = substr($_SERVER["SCRIPT_NAME"],strrpos($_SERVER["SCRIPT_NAME"],"/")+1);
$url = 'http://votingapi.com/validate.php?user=FINDRETRONAME&ip=' . $userip;
$context = stream_context_create(array('http' => array('timeout' => 1)));
$data = @file_get_contents($url, 1, $context);
if(!$data || !is_numeric($data)) {
return "Error";
}
else if ($data == 1 || $data == 2) {
}
else {
header ("Location: http://votingapi.com/vote.php?username=FINDRETROSNAME&api=http:!!HOTELURL!index?novote");
exit;
}
}
?>

Please don’t try that.

 

[Berk]

try this in your forcevote.php

<?php
if(isset($_GET['voted'])) {
}
else {
$userip = "{$_SERVER['REMOTE_ADDR']}";
$current_url = substr($_SERVER["SCRIPT_NAME"],strrpos($_SERVER["SCRIPT_NAME"],"/")+1);
$url = 'http://votingapi.com/validate.php?user=FINDRETRONAME&ip=' . $userip;
$context = stream_context_create(array('http' => array('timeout' => 1)));
$data = @file_get_contents($url, 1, $context);
if(!$data || !is_numeric($data)) {
return "Error";
}
else if ($data == 1 || $data == 2) {
}
else {
header ("Location: http://votingapi.com/vote.php?username=FINDRETROSNAME&api=http:!!HOTELURL!index?novote");
exit;
}
}
?>

Didn't work

 

[Sly]

guess it's outdated. @RastaLulz didn't you create findretros. Help the guy out.

 

[JynX]

Your issue is the fact that you're checking if they have voted and redirecting them to the client.

If they are on the client when this check is ran and they HAVE voted it will just endlessly redirect forever. Chrome stops this by throwing the error that you posted which stops the endless loop. This code is also not good considering they won't be able to access ANY other page than the client after they have voted.

Check Josh's vote validator on Github here:

You must be registered for see links

In case you're lazy you can just use the following instead of the code you have..

<?php

require_once 'findretros_config.php';
require_once 'findretros.php';

$FindRetros = new FindRetros();

if($FindRetros->hasClientVoted()) {

}else{
    $FindRetros->redirectClientToVote();
}

 

[Berk]

Your issue is the fact that you're checking if they have voted and redirecting them to the client.

If they are on the client when this check is ran and they HAVE voted it will just endlessly redirect forever. Chrome stops this by throwing the error that you posted which stops the endless loop. This code is also not good considering they won't be able to access ANY other page than the client after they have voted.

Check Josh's vote validator on Github here:

You must be registered for see links

In case you're lazy you can just use the following instead of the code you have..

<?php

require_once 'findretros_config.php';
require_once 'findretros.php';

$FindRetros = new FindRetros();

if($FindRetros->hasClientVoted()) {

}else{
    $FindRetros->redirectClientToVote();
}

thanks, this worked!

 

[Weasel]

Your issue is the fact that you're checking if they have voted and redirecting them to the client.

If they are on the client when this check is ran and they HAVE voted it will just endlessly redirect forever. Chrome stops this by throwing the error that you posted which stops the endless loop. This code is also not good considering they won't be able to access ANY other page than the client after they have voted.

Check Josh's vote validator on Github here:

You must be registered for see links

In case you're lazy you can just use the following instead of the code you have..

<?php

require_once 'findretros_config.php';
require_once 'findretros.php';

$FindRetros = new FindRetros();

if($FindRetros->hasClientVoted()) {

}else{
    $FindRetros->redirectClientToVote();
}

<?php

require_once('findretros_config.php');
require_once('findretros.php');

$findRetros = new FindRetros();

if (!$findRetros->hasClientVoted()) {
    $findRetros->redirectClientToVote();
}

You can simply do this, no need for an empty if statement.

 

[JynX]

<?php

require_once('findretros_config.php');
require_once('findretros.php');

$findRetros = new FindRetros();

if (!$findRetros->hasClientVoted()) {
    $findRetros->redirectClientToVote();
}

You can simply do this, no need for an empty if statement.

True, didn't really look @ the code more or less copied from the Git's example and removed the echo's. But yeah, use his.