Reply to thread

Message

<blockquote data-quote="Sledmore" data-source="post: 477496" data-attributes="member: 591">Nice release, but I'd be surprised if it doesn't error as $nombre isn't defined? I would say you should also use prepared statements, but you have some JS for filtering so I don't think you even need that query, I'd change:[PHP]$sql = &quot;SELECT * FROM catalogo_zayter WHERE nombre LIKE '%$nombre%' ORDER BY nombre&quot;;[/PHP]To:[PHP]$sql = &quot;SELECT * FROM catalogo_zayter ORDER BY nombre&quot;;[/PHP]I would probably also make a slight change to:[PHP]echo &quot;&lt;div class='col-lg-6 col-xl-4 order-first'&gt;&quot;;[/PHP]Change to:[PHP]echo &quot;&lt;div class='col-lg-6 col-xl-4 order-first rare-entry'&gt;&quot;;[/PHP]And:[CODE=javascript]$(&quot;.card&quot;).filter(function() {[/CODE]To:[CODE=javascript]$(&quot;.rare-entry&quot;).filter(function() {[/CODE]That way you don't have empty divs making space.It's a nice release, just seems unneccessarily heavily. Calling image assets from habborator, habboassets &amp; habbo, and then on top of that lots of other dependencies.</blockquote>

[QUOTE="Sledmore, post: 477496, member: 591"] Nice release, but I'd be surprised if it doesn't error as $nombre isn't defined? I would say you should also use prepared statements, but you have some JS for filtering so I don't think you even need that query, I'd change: [PHP]$sql = "SELECT * FROM catalogo_zayter WHERE nombre LIKE '%$nombre%' ORDER BY nombre";[/PHP] To: [PHP]$sql = "SELECT * FROM catalogo_zayter ORDER BY nombre";[/PHP] I would probably also make a slight change to: [PHP]echo "<div class='col-lg-6 col-xl-4 order-first'>";[/PHP] Change to: [PHP]echo "<div class='col-lg-6 col-xl-4 order-first rare-entry'>";[/PHP] And: [CODE=javascript]$(".card").filter(function() {[/CODE] To: [CODE=javascript]$(".rare-entry").filter(function() {[/CODE] That way you don't have empty divs making space. It's a nice release, just seems unneccessarily heavily. Calling image assets from habborator, habboassets & habbo, and then on top of that lots of other dependencies. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members