Reply to thread

Message

<blockquote data-quote="Jaden" data-source="post: 397892" data-attributes="member: 51705">I refactored this a bit.RigDiceCommand.cs[CODE]using System;using System.Collections.Generic;using System.Linq;using System.Text;using System.Threading.Tasks;using Plus.HabboHotel.GameClients;using Plus.HabboHotel.Rooms;using Plus.HabboHotel.Rooms.Chat.Commands;namespace Plus.HabboHotel.Roleplay.Commands.Builder{&nbsp; &nbsp; internal sealed class RigDiceCommand : IChatCommand&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; public string PermissionRequired =&gt; &quot;command_rigdice&quot;;&nbsp; &nbsp; &nbsp; &nbsp; public string Parameters =&gt; &quot;%username% %sequence%&quot;;&nbsp; &nbsp; &nbsp; &nbsp; public string Description =&gt; &quot;Set predetermined dice outcome(s) without any randomization.&quot;;&nbsp; &nbsp; &nbsp; &nbsp; public void Execute(GameClient session, Room room, string[] Params)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (Params.Length == 1)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(&quot;Syntax error! Usage: :rigdice &lt;username&gt; &lt;sequence (0-6, 0-6..)&gt;&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // contemplating whether values should be stored in the RoomUser.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; GameClient target = PlusEnvironment.GetGame().GetClientManager().GetClientByUsername(Params[1]);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (target == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(&quot;Couldn't find user &quot; + Params[1] + &quot; in this room!&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // to be used by trusted staff, or convert to array and limit values.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string input = String.Concat(Params.Skip(2).ToArray()).Replace(&quot; &quot;, string.Empty);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // pre-allocated memory list configured for 5 insertions.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; List&lt;uint&gt; sequence = new List&lt;uint&gt;(5);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (string element in input.Split(','))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; uint number;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!uint.TryParse(element, out number))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(element + &quot; isn't a valid positive integer.&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (number &gt; 6)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(&quot;Sequence cannot contain numbers greater than 6!&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; sequence.Add(number);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (target.GetHabbo().DiceSequence != null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // add the new sequence to the end of the old sequence (remove if not wanted).&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; lock (target.GetHabbo().DiceSequence)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; List&lt;uint&gt; copySequence = new List&lt;uint&gt;(target.GetHabbo().DiceSequence.Count + sequence.Count);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; copySequence.AddRange(target.GetHabbo().DiceSequence);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; copySequence.AddRange(sequence);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; target.GetHabbo().DiceSequence = copySequence;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(&quot;Added to &quot; + target.GetHabbo().Username + &quot;'s current dice sequence.&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; target.GetHabbo().DiceSequence = sequence;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // notify the caller that we're finished.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; session.SendWhisper(&quot;Created &quot; + target.GetHabbo().Username + &quot;'s dice sequence.&quot;);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }}[/CODE]Habbo.cs (Habbo class, I added under the &quot;Just random fun stuff&quot; comment)[CODE]public List&lt;uint&gt; DiceSequence;[/CODE]My InteractionType.DICE case code[CODE]string[] numbers = new string[] { &quot;1&quot;, &quot;2&quot;, &quot;3&quot;, &quot;4&quot;, &quot;5&quot;, &quot;6&quot; };if (ExtraData == &quot;-1&quot;){&nbsp; &nbsp; User = GetRoom().GetRoomUserManager().GetRoomUserByHabbo(InteractingUser);&nbsp; &nbsp; if (User.GetClient().GetHabbo().DiceSequence != null)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; ExtraData = User.GetClient().GetHabbo().DiceSequence[0].ToString();&nbsp; &nbsp; &nbsp; &nbsp; User.GetClient().GetHabbo().DiceSequence.RemoveAt(0);&nbsp; &nbsp; &nbsp; &nbsp; // properly dispose of the DiceSequence list.&nbsp; &nbsp; &nbsp; &nbsp; if (!User.GetClient().GetHabbo().DiceSequence.Any())&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; User.GetClient().GetHabbo().DiceSequence = null;&nbsp; &nbsp; }&nbsp; &nbsp; else&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; ExtraData = RandomizeStrings(numbers)[0];&nbsp; &nbsp; }}UpdateState();[/CODE]</blockquote>

[QUOTE="Jaden, post: 397892, member: 51705"] I refactored this a bit. RigDiceCommand.cs [CODE]using System; using System.Collections.Generic; using System.Linq; using System.Text; using System.Threading.Tasks; using Plus.HabboHotel.GameClients; using Plus.HabboHotel.Rooms; using Plus.HabboHotel.Rooms.Chat.Commands; namespace Plus.HabboHotel.Roleplay.Commands.Builder { internal sealed class RigDiceCommand : IChatCommand { public string PermissionRequired => "command_rigdice"; public string Parameters => "%username% %sequence%"; public string Description => "Set predetermined dice outcome(s) without any randomization."; public void Execute(GameClient session, Room room, string[] Params) { if (Params.Length == 1) { session.SendWhisper("Syntax error! Usage: :rigdice <username> <sequence (0-6, 0-6..)>"); return; } // contemplating whether values should be stored in the RoomUser. GameClient target = PlusEnvironment.GetGame().GetClientManager().GetClientByUsername(Params[1]); if (target == null) { session.SendWhisper("Couldn't find user " + Params[1] + " in this room!"); return; } // to be used by trusted staff, or convert to array and limit values. string input = String.Concat(Params.Skip(2).ToArray()).Replace(" ", string.Empty); // pre-allocated memory list configured for 5 insertions. List<uint> sequence = new List<uint>(5); foreach (string element in input.Split(',')) { uint number; if (!uint.TryParse(element, out number)) { session.SendWhisper(element + " isn't a valid positive integer."); return; } if (number > 6) { session.SendWhisper("Sequence cannot contain numbers greater than 6!"); return; } sequence.Add(number); } if (target.GetHabbo().DiceSequence != null) { // add the new sequence to the end of the old sequence (remove if not wanted). lock (target.GetHabbo().DiceSequence) { List<uint> copySequence = new List<uint>(target.GetHabbo().DiceSequence.Count + sequence.Count); copySequence.AddRange(target.GetHabbo().DiceSequence); copySequence.AddRange(sequence); target.GetHabbo().DiceSequence = copySequence; } session.SendWhisper("Added to " + target.GetHabbo().Username + "'s current dice sequence."); return; } target.GetHabbo().DiceSequence = sequence; // notify the caller that we're finished. session.SendWhisper("Created " + target.GetHabbo().Username + "'s dice sequence."); } } } [/CODE] Habbo.cs (Habbo class, I added under the "Just random fun stuff" comment) [CODE]public List<uint> DiceSequence;[/CODE] My InteractionType.DICE case code [CODE]string[] numbers = new string[] { "1", "2", "3", "4", "5", "6" }; if (ExtraData == "-1") { User = GetRoom().GetRoomUserManager().GetRoomUserByHabbo(InteractingUser); if (User.GetClient().GetHabbo().DiceSequence != null) { ExtraData = User.GetClient().GetHabbo().DiceSequence[0].ToString(); User.GetClient().GetHabbo().DiceSequence.RemoveAt(0); // properly dispose of the DiceSequence list. if (!User.GetClient().GetHabbo().DiceSequence.Any()) User.GetClient().GetHabbo().DiceSequence = null; } else { ExtraData = RandomizeStrings(numbers)[0]; } } UpdateState();[/CODE] [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members