Reply to thread

Message

<blockquote data-quote="Khalil" data-source="post: 228916" data-attributes="member: 9938">This...this is just so wrong in many ways!First of all, you forgot the semicolons in your mysql configuration.[PHP]$db_name=&quot;user&quot;;// Database name$tbl_name=&quot;user&quot;;// Table name[/PHP]Your mysql connection script is pretty fucked, so heres the fix:[PHP]mysql_connect($host, $username, $password)or die(&quot;cannot connect&quot;);mysql_select_db($db_name)or die(&quot;cannot select DB&quot;);[/PHP]Your login page is fucked:[HTML]&lt;table&gt; width=&quot;300&quot; border=&quot;0&quot;align=&quot;center&quot; cellpadding=&quot;0&quot;cellspacing=&quot;1&quot; bgcolor=#CCCCCC&gt;&nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;form name=&quot;form1&quot; method=&quot;post&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; action=&quot;checklogin.php&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;table width=&quot;100%&quot; border=&quot;0&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; cellpaddng=&quot;3&quot; cellspacing=&quot;1&quot;bgcolor=&quot;#FFFFFF&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt; width=&quot;78&quot;&gt;Username&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;width=&quot;6&quot;&gt;:&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt; width=&quot;294&quot;&gt;&lt;input&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; name=&quot;Bradley&quot; type=&quot;text&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; id=&quot;Bradley&quot;&gt;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;Password&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;:&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&lt;input name=&quot;brad123&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; type=&quot;text&quot; id=brad123&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&amp;nbsp;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&amp;nbsp;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&lt;input type =&quot;submit&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; name=&quot;Submit&quot; value=&quot;Login&quot;&gt;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/table&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/form&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&lt;/table&gt;[/HTML]Fix:[HTML]&lt;table width=&quot;300&quot; border=&quot;0&quot;align=&quot;center&quot; cellpadding=&quot;0&quot;cellspacing=&quot;1&quot; bgcolor=#CCCCCC&gt;&nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;form name=&quot;form1&quot; method=&quot;post&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; action=&quot;checklogin.php&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;table width=&quot;100%&quot; border=&quot;0&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; cellpaddng=&quot;3&quot; cellspacing=&quot;1&quot;bgcolor=&quot;#FFFFFF&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td width=&quot;78&quot;&gt;Username&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td width=&quot;6&quot;&gt;:&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td width=&quot;294&quot;&gt;&lt;input&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; name=&quot;Bradley&quot; type=&quot;text&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; id=&quot;Bradley&quot;&gt;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;Password&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;:&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&lt;input name=&quot;brad123&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; type=&quot;text&quot; id=brad123&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&amp;nbsp;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&amp;nbsp;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;td&gt;&lt;input type =&quot;submit&quot;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; name=&quot;Submit&quot; value=&quot;Login&quot;&gt;&lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/table&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/td&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/form&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/tr&gt;&lt;/table&gt;[/HTML]In the checklogin.php, two lines are pretty fucked up and that would ruin the rest of the script, there are the lines and under them is the fix:Fucked up line:[PHP]$myusername=&quot;_POST['myusername'][/PHP]Fix:[PHP]$myusername=$_POST['myusername'];[/PHP]And, the the name in the username input is &quot;Bradley&quot; and in the pass input is &quot;brad123&quot;, they should be &quot;myusername&quot; and &quot;mypassword&quot; for this script to function.Oh and this line is fucked up too:[PHP]session_register(&quot;myusername);[/PHP]Fix:[PHP]session_register(&quot;myusername&quot;);[/PHP]And next time, if you want to comment a line, don't forget the slashes in the start otheriwse it'll output that line in the page:[PHP]// and redirect to file &quot;login_succcess.php&quot;[/PHP]Oh and your login_success page, you forgot to comment the three first lines:By the looks of it, you wanted the user of this script to read those lines but not output them in the page or show them in the code source, you could have just included them between the php tags and added the two slashes to the start of the second line.[PHP]//Check if session is not registered,//redirect back to main page.//Put this code in first line of web page. [/PHP]P.S: Next time, secure the info with hashing or encryption.</blockquote>

[QUOTE="Khalil, post: 228916, member: 9938"] This...this is just so wrong in many ways! First of all, you forgot the semicolons in your mysql configuration. [PHP]$db_name="user";// Database name $tbl_name="user";// Table name[/PHP] Your mysql connection script is pretty fucked, so heres the fix: [PHP]mysql_connect($host, $username, $password)or die("cannot connect"); mysql_select_db($db_name)or die("cannot select DB");[/PHP] Your login page is fucked: [HTML] <table> width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor=#CCCCCC> <tr> <form name="form1" method="post" action="checklogin.php"> <td> <table width="100%" border="0" cellpaddng="3" cellspacing="1" bgcolor="#FFFFFF"> <tr> <td> width="78">Username</td> <td>width="6">:</td> <td> width="294"><input name="Bradley" type="text" id="Bradley"></td> </tr> <tr> <td>Password</td> <td>:</td> <td><input name="brad123" type="text" id=brad123</td> </tr> <td> </td> <td> </td> <td><input type ="submit" name="Submit" value="Login"></td> </tr> </table> </td> </form> </tr> </table> [/HTML] Fix: [HTML] <table width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor=#CCCCCC> <tr> <form name="form1" method="post" action="checklogin.php"> <td> <table width="100%" border="0" cellpaddng="3" cellspacing="1" bgcolor="#FFFFFF"> <tr> <td width="78">Username</td> <td width="6">:</td> <td width="294"><input name="Bradley" type="text" id="Bradley"></td> </tr> <tr> <td>Password</td> <td>:</td> <td><input name="brad123" type="text" id=brad123</td> </tr> <td> </td> <td> </td> <td><input type ="submit" name="Submit" value="Login"></td> </tr> </table> </td> </form> </tr> </table> [/HTML] In the checklogin.php, two lines are pretty fucked up and that would ruin the rest of the script, there are the lines and under them is the fix: Fucked up line: [PHP] $myusername="_POST['myusername'] [/PHP] Fix: [PHP] $myusername=$_POST['myusername']; [/PHP] And, the the name in the username input is "Bradley" and in the pass input is "brad123", they should be "myusername" and "mypassword" for this script to function. Oh and this line is fucked up too: [PHP]session_register("myusername);[/PHP] Fix: [PHP]session_register("myusername");[/PHP] And next time, if you want to comment a line, don't forget the slashes in the start otheriwse it'll output that line in the page: [PHP]// and redirect to file "login_succcess.php"[/PHP] Oh and your login_success page, you forgot to comment the three first lines: By the looks of it, you wanted the user of this script to read those lines but not output them in the page or show them in the code source, you could have just included them between the php tags and added the two slashes to the start of the second line. [PHP] //Check if session is not registered, //redirect back to main page. //Put this code in first line of web page. [/PHP] P.S: Next time, secure the info with hashing or encryption. [/QUOTE]

Verification

Reply to thread

Connect with us

Newest members